BYNT-1400: Handle new ID number in Sheet Import (BE)#141
Merged
Conversation
tarekio
approved these changes
Jul 26, 2025
level09
reviewed
Jul 26, 2025
| """ | ||
| Method to set idnumbers. | ||
| """ | ||
| id_number_types = [str(t.id) for t in IDNumberType.query.all()] |
Collaborator
There was a problem hiding this comment.
- For new code, we gotta move away from legacy sqlalchemy 1.x syntax and use sqlalchemy 2.x
- we have to get the types only once per import not query db for every row. we could take it outside or use
@cached_property
Contributor
Author
## Jira Issue 1. [BYNT-1399](https://syriajustice.atlassian.net/browse/BYNT-1399) ## Description Update id number component in sheetimport page ## Checklist - [ ] Tests added/updated - [ ] Documentation updated (if needed) - [ ] New strings prepared for translations ## API Changes (if applicable) - [ ] Permissions checked - [ ] Endpoint tests added ## Additional Notes [Any other relevant information] [BYNT-1399]: https://syriajustice.atlassian.net/browse/BYNT-1399?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: tarekio <7659394+tarekio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
id_numberafter events in SheetImportChecklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]