BYNT-1370/1/2: ID Number Types and Actor.id_number migration#121
Merged
BYNT-1370/1/2: ID Number Types and Actor.id_number migration#121
Conversation
Add IDNumberType implementation following dialect/ethnography pattern: - Model with ComponentDataMixin for title/title_tr fields - CRUD API endpoints with admin role restrictions and activity logging - Frontend component data page updates - Database migration with default types (National ID, Passport, etc.) - Data import command updated to include ID Number Types (with defaults from enferno/data/id_number_types.csv) - Test coverage and API documentation
level09
reviewed
Jun 25, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
This PR is good. my comments are really just for code/style consistency.
level09
approved these changes
Jun 26, 2025
## Jira Issue 1. [BYNT-1372](https://syriajustice.atlassian.net/browse/BYNT-1372) ## Description - Add migration to migrate Actor.id_number to JSONB array - Add test script to verify data integrity - Modify DELETE IDNumberType endpoint to check for references in Actor.id_number - Add database constraints to ensure data integrity ## Checklist - [x] Tests added/updated - [ ] Documentation updated (if needed) - [ ] New strings prepared for translations ## API Changes (if applicable) - [ ] Permissions checked - [ ] Endpoint tests added ## Additional Notes [Any other relevant information] [BYNT-1372]: https://syriajustice.atlassian.net/browse/BYNT-1372?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
level09
requested changes
Jun 26, 2025
…ndancy; ui/ux: make id_number inline editable
level09
approved these changes
Jun 27, 2025
…g/bayanat into bynt-1371-id-number-types
…val complexity efficiently with caching. api doc updates.
Contributor
|
@tarekio the feedback has been addressed |
tarekio
approved these changes
Jun 30, 2025
level09
requested changes
Jul 1, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
Guys, We Gotta simplify this 🫵
…ifications per level09's review
… in a lot of places
Contributor
|
@level09 i made some updates based on your feedback, should be much simpler now |
level09
reviewed
Jul 5, 2025
- Streamline id_number assignment in from_json method - Replace _get_formatted_id_numbers() with inline list comprehension
level09
reviewed
Jul 7, 2025
Co-authored-by: Nidal Alhariri <level09@gmail.com>
level09
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
Add IDNumberType implementation following dialect/ethnography pattern:
Actor.id_number
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]