Merged
Conversation
…367-implement-new-login-design
…367-implement-new-login-design
…recovery button to other pages
level09
reviewed
Jul 5, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
This is nice.
Can we try integrating a few Vuetify core colors ?
rgb(var(--v-theme-surface)) /* Background colors */
rgb(var(--v-theme-on-surface)) /* Text on backgrounds */
rgb(var(--v-theme-on-surface-variant)) /* Muted text */
rgb(var(--v-theme-outline-variant)) /* Borders */
var(--v-shadow-key-elevation-2) /* Card shadows */
The migration should be super simple, You could literally just find/replace:
- white → rgb(var(--v-theme-surface))
- #000 → rgb(var(--v-theme-on-surface))
- #F4F4F4 → rgb(var(--v-theme-outline-variant))
this will give us automatic flip of colors in dark mode, and uses the same Vuetify palette for v-cards, v-buttons and other components; also preserves the exact appearance with no visual changes; and remains easy to maintain.
level09
reviewed
Jul 5, 2025
Contributor
Author
|
@level09 i removed the custom login styles and used default vuetify classes, it looks almost the same i hope it's better now |
…367-implement-new-login-design
level09
approved these changes
Jul 15, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
This is good as is , we can improve and centralize css colors later .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
Implement new login design, this includes 2fa pages and recovery code page
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]