Skip to content

Implement new login design#116

Merged
tarekio merged 22 commits intomainfrom
BYNT-1367-implement-new-login-design
Jul 17, 2025
Merged

Implement new login design#116
tarekio merged 22 commits intomainfrom
BYNT-1367-implement-new-login-design

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Jun 20, 2025

Jira Issue

  1. BYNT-1367

Description

Implement new login design, this includes 2fa pages and recovery code page

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron requested a review from tarekio June 20, 2025 14:30
@apodacaduron apodacaduron self-assigned this Jun 20, 2025
Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good.

@tarekio tarekio requested a review from level09 June 23, 2025 19:53
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice.

Can we try integrating a few Vuetify core colors ?

  rgb(var(--v-theme-surface))           /* Background colors */
  rgb(var(--v-theme-on-surface))        /* Text on backgrounds */
  rgb(var(--v-theme-on-surface-variant)) /* Muted text */
  rgb(var(--v-theme-outline-variant))   /* Borders */
  var(--v-shadow-key-elevation-2)       /* Card shadows */

The migration should be super simple, You could literally just find/replace:

  • white → rgb(var(--v-theme-surface))
  • #000 → rgb(var(--v-theme-on-surface))
  • #F4F4F4 → rgb(var(--v-theme-outline-variant))

this will give us automatic flip of colors in dark mode, and uses the same Vuetify palette for v-cards, v-buttons and other components; also preserves the exact appearance with no visual changes; and remains easy to maintain.

@apodacaduron
Copy link
Contributor Author

@level09 i removed the custom login styles and used default vuetify classes, it looks almost the same i hope it's better now

@apodacaduron apodacaduron requested a review from level09 July 10, 2025 18:58
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good as is , we can improve and centralize css colors later .

@tarekio tarekio merged commit 8e30279 into main Jul 17, 2025
6 of 7 checks passed
@tarekio tarekio deleted the BYNT-1367-implement-new-login-design branch July 17, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants