Skip to content

Implement better handling of server responses in handle request error#114

Merged
tarekio merged 7 commits intomainfrom
BYNT-1366-implement-better-handling-of-server-responses-in-handle-request-error
Jun 29, 2025
Merged

Implement better handling of server responses in handle request error#114
tarekio merged 7 commits intomainfrom
BYNT-1366-implement-better-handling-of-server-responses-in-handle-request-error

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Jun 18, 2025

Jira Issue

  1. BYNT-1366

Description

Currently snackbar will render the html response as is, this PR better detects html response and replaces it with a plain string "An error ocurred"

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron requested a review from tarekio June 18, 2025 17:51
@apodacaduron apodacaduron self-assigned this Jun 18, 2025
@tarekio tarekio requested a review from level09 June 20, 2025 16:34
Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@tarekio tarekio merged commit be11a39 into main Jun 29, 2025
6 of 7 checks passed
@tarekio tarekio deleted the BYNT-1366-implement-better-handling-of-server-responses-in-handle-request-error branch June 29, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants