Secondary language not displayed in preview#113
Merged
Conversation
tarekio
approved these changes
Jun 18, 2025
level09
approved these changes
Jun 20, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
Looks good, I just recommend using core vuetify styles to avoid adding redundant styles
| .z-1 { | ||
| z-index: 1; | ||
| } | ||
| .pi-0 { |
Collaborator
There was a problem hiding this comment.
I think we already have pe-0 in vuetify core
Contributor
Author
There was a problem hiding this comment.
Right i dont even needed to add pi-0 even using px-0 works, my mistake, since this is already merged i'll probably change this in another PR since it's a small change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
EventCard.js is only rendering english text in the previews, it should also render arabic translations
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]