Conversation
tarekio
approved these changes
Jun 16, 2025
Contributor
tarekio
left a comment
There was a problem hiding this comment.
Works well, need to confirm with user testing though.
level09
reviewed
Jun 19, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
@cango91 for actor tags, data is likely will be big. we will need to add a proper index for actor tags
I suggest GIN index with array_ops operator class , that is good for array operations.
Let's add :
- sqlalchemy index
- migration script for addding the index
lets make sure the index name is the same in both cases.
…, and cleanup - Add GIN index with array_ops for actor tags to improve search performance - Add regex escaping to all tag search operations for security - Remove confusing "De Morgan's" comment - Create migration script for the new index
level09
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
tagsas an optional parameter for Actors search where search capabilities are modeled after the Bulletin tags search.Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]