Conversation
level09
approved these changes
Jun 14, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
This is good, it improves the initial state of the language switch, but the component still allows the user to toggle to a blank field if one language is missing.
my seggestion :
Update the template so that:
- If both english and arabic exist, the toggle works as now.
- If only one exists, always show the available one, regardless of the switch, and hide the toggle button.
This ensures the user never sees a blank field and the UI always has something.
<v-list v-if="english || arabic" ...>
<!-- Both exist: allow switching -->
<template v-if="english && arabic">
<v-list-item :title="caption" v-if="sw" density="compact">
<v-sheet class="text-body-2">{{ english }}</v-sheet>
<template #append>
<v-btn variant="text" size="x-small" icon="mdi-web" @click="sw = !sw"></v-btn>
</template>
</v-list-item>
<v-list-item :title="caption" v-else density="compact">
<v-sheet class="text-body-2">{{ arabic }}</v-sheet>
<template #append>
<v-btn variant="text" size="x-small" icon="mdi-web" @click="sw = !sw"></v-btn>
</template>
</v-list-item>
</template>
<!-- Only one exists: show it, no toggle -->
<template v-else>
<v-list-item :title="caption" density="compact">
<v-sheet class="text-body-2">{{ english || arabic }}</v-sheet>
</v-list-item>
</template>
</v-list>
Contributor
|
@level09 made an update based on your feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
[Brief description of changes]
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]