Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes multiple issues related to sheet imports, including parsing single tags, matching dynamic event types and locations, processing an estimated flag, and setting a temporary actor name.
- Modified actor name assignment from "Temp" to "TEMP".
- Trimmed values in location matching and improved tag parsing logic.
- Added estimated date handling and updated actor name logic based on provided name fields.
Comments suppressed due to low confidence (2)
enferno/data_import/utils/sheet_import.py:583
- Avoid using 'type' as a variable name since it shadows the built-in function; consider renaming it to 'event_type'.
type = event.get("type")
enferno/data_import/utils/sheet_import.py:809
- [nitpick] Consider adding a clarifying comment to explain the logic behind resetting actor.name to an empty string or to 'UNKNOWN UNKNOWN' based on the presence of other name fields.
if self.actor.name == "TEMP":
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
This PR address several issues:
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]