Skip to content

Refactor/channels subpackages#540

Closed
alexhoshina wants to merge 7 commits intosipeed:mainfrom
alexhoshina:refactor/channels-subpackages
Closed

Refactor/channels subpackages#540
alexhoshina wants to merge 7 commits intosipeed:mainfrom
alexhoshina:refactor/channels-subpackages

Conversation

@alexhoshina
Copy link
Collaborator

@alexhoshina alexhoshina commented Feb 20, 2026 •
edited
Loading

📝 Description

Currently, all channel implementation files under pkg/channels/ (12 channels, 20+ files) reside in the same package channels. As the number of channels grows, the directory becomes bloated and difficult to maintain. This refactoring splits each channel into its own subdirectory/subpackage, making the code structure clearer and the responsibility boundaries of each channel more explicit.

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

@alexhoshina alexhoshina marked this pull request as ready for review February 20, 2026 15:38
@alexhoshina alexhoshina mentioned this pull request Feb 21, 2026
Merged
4 tasks
xiaket
xiaket reviewed Feb 21, 2026
View reviewed changes
xiaket
xiaket reviewed Feb 21, 2026
View reviewed changes
xiaket
xiaket reviewed Feb 21, 2026
View reviewed changes
xiaket
xiaket reviewed Feb 21, 2026
View reviewed changes
xiaket
xiaket reviewed Feb 21, 2026
View reviewed changes
xiaket
xiaket approved these changes Feb 21, 2026
View reviewed changes
Copy link
Collaborator

@xiaket xiaket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, left some nit comments for you to consider.

@xiaket
Copy link
Collaborator

xiaket commented Feb 21, 2026

cc @yinwm

@alexhoshina alexhoshina force-pushed the refactor/channels-subpackages branch from c96b400 to a7b895f Compare February 22, 2026 03:10
@alexhoshina alexhoshina force-pushed the refactor/channels-subpackages branch from a7b895f to fbc85a8 Compare February 22, 2026 03:23
@alexhoshina
Copy link
Collaborator Author

alexhoshina commented Feb 22, 2026

Overall LGTM, left some nit comments for you to consider.

Thank you for your attention to detail. @xiaket

@alexhoshina
Copy link
Collaborator Author

alexhoshina commented Feb 25, 2026

Already included in the channel refactoring, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaket xiaket xiaket approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexhoshina @xiaket