Closed
Conversation
Collaborator
Author
|
Happy to resolve the conflicts, but would want some confirmation that this is where we want to be. |
Collaborator
|
@Zepan This PR refactors While Cobra is a solid choice for Go CLIs, this is a high-risk refactor that touches the core startup path. With 68+ open PRs in flight, merging this now would create conflicts for virtually every other PR that touches Recommendation: Defer to a stabilization window. This is good work but the timing is challenging — it should ideally land when the PR queue is smaller to minimize merge conflicts across the board. |
10 tasks
Signed-off-by: Kai Xia <kaix+github@fastmail.com>
Signed-off-by: Kai Xia <kaix+github@fastmail.com>
93ef51c to
f21906c
Compare
Collaborator
Author
|
Closing this as provider work is going in. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor main.go to use cobra, making it much more readable and maintainable.
It is to be noted that some cli behaviour has changed, for example, for some flags, main.go before refactor will do a
returnin the sub-command(for example, here), resulting in a exit code of 0. I would argue that this is wrong, and this PR will correct this behaviour.