Sanity checks on final miniscript produced by Parse

meshcollider · meshcollider · commit dcaf9ac6a62e · 2021-12-04T17:48:14.000+13:00
diff --git a/bitcoin/script/miniscript.h b/bitcoin/script/miniscript.h
@@ -1208,9 +1208,13 @@ inline NodeRef<Key> Parse(Span<const char>& in, const Ctx& ctx)
         }
         }
     }
+
+    // Sanity checks on the produced miniscript
     assert(constructed.size() == 1);
     if (iter != in.end()) return {};
-    return constructed.front();
+    const NodeRef<Key> tl_node = std::move(constructed.front());
+    if (!tl_node->IsValidTopLevel()) return {};
+    return tl_node;
 }
 
 /** Decode a script into opcode/push pairs.

Original file line number	Diff line number	Diff line change
`@@ -1208,9 +1208,13 @@ inline NodeRef<Key> Parse(Span<const char>& in, const Ctx& ctx)`
`1208`	`1208`	`}`
`1209`	`1209`	`}`
`1210`	`1210`	`}`
	`1211`	`+`
	`1212`	`+ // Sanity checks on the produced miniscript`
`1211`	`1213`	`assert(constructed.size() == 1);`
`1212`	`1214`	`if (iter != in.end()) return {};`
`1213`		`- return constructed.front();`
	`1215`	`+ const NodeRef<Key> tl_node = std::move(constructed.front());`
	`1216`	`+ if (!tl_node->IsValidTopLevel()) return {};`
	`1217`	`+ return tl_node;`
`1214`	`1218`	`}`
`1215`	`1219`
`1216`	`1220`	`/** Decode a script into opcode/push pairs.`