Restore sinon.createStubInstance() behaviour#2075
Merged
mroderick merged 1 commit intosinonjs:masterfrom Sep 2, 2019
Merged
Conversation
Pull Request Test Coverage Report for Build 2944
💛 - Coveralls |
PR sinonjs#2022 redirected sinon.createStubInstance() to use the Sandbox implementation thereof. This introduced a breaking change due to the sandbox implementation not supporting property overrides. Instead of duplicating the original behaviour from stub.js into sandbox.js, call through to the stub.js implementation then add all the stubs to the sandbox collection as usual. Copy the missing tests from stub-test.js and add issue tests.
2816c27 to
a2110fc
Compare
1 task
mroderick
approved these changes
Sep 2, 2019
Member
mroderick
left a comment
There was a problem hiding this comment.
Excellent work! Thank you for your contribution to Sinon!
Member
|
This has been published as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fix issue #2073 by reusing
createStubInstance()behaviour fromstub.jswhile maintaining the sandboxcollection.Background (Problem in detail) - optional
PR #2022 redirected
sinon.createStubInstance()to use the Sandbox implementation thereof. This introduced a breaking change due to the sandbox implementation not supporting property overrides.Solution - optional
This PR extends
sandbox.createStubInstance()to mimic the behaviour of the originalsinon.createStubInstance()method.Instead of duplicating the original
createStubInstance()behaviour fromstub.jsintosandbox.js, it now calls through to thestub.jsimplementation, then adds all the stubs to the sandboxcollectionas usual.The extra tests for property overrides in
stub-test.jshave also been added tosandbox-test.jsto ensure the sandbox implementation now works the same as the originalcreateStubInstance(), while maintaining backward compatibility with all existing sandbox tests.EDIT: Added some specific tests for issue #2073 in
issues-test.js.How to verify - mandatory
npm installnpm testChecklist for author
npm run lintpasses