Add missing package#418
Merged
vsoch merged 1 commit intosingularityhub:masterfrom Mar 27, 2023
SethosII:patch-2
Merged
Conversation
Package python-jose is required for LDAP authentication.
Member
|
Should this perhaps be here as another line Line 55 in 1cce4be |
Contributor
Author
|
I don't think it's only required for LDAP. I also checked it and social-auth-core has it listed as a requirement. A quick search in their GitHub repository shows no LDAP specific things. |
Member
|
That works for me then - it's worrisome they don't install one of their dependencies and put that burden on us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package python-jose is required for LDAP authentication.