Predev channels caching #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch 2.1.4 - Reducing the default parameter payment-channel-connection-timeout from 100 seconds to 7 seconds
Added FileCoin storage provider for services metadata and files
Merge to predev
…ng" field in metadata.
Hide UserWarnings at the time the logs processing
kiruxaspb
reviewed
Oct 29, 2024
| contract_events = map(lambda e: e["name"], filter(lambda e: e["type"] == "event", self.abi)) | ||
| for contract_event in contract_events: | ||
| events.extend(getattr(self.contract.events, contract_event)().process_receipt(receipt)) | ||
| events.extend(getattr(self.contract.events, contract_event)().process_receipt(receipt, errors=DISCARD)) |
Member
There was a problem hiding this comment.
Here we ignoring UserWarnings from Web3, more about here.
…dded "filecoin_api_key" option to "unset" command.
kiruxaspb
requested changes
Nov 8, 2024
Member
kiruxaspb
left a comment
There was a problem hiding this comment.
Need to add backward compatibility with configurations created by older versions of the CLI.
with configs created older CLI versions
…ith-configs-created-older-versions Added backward compatibility
Member
Added in #524 |
kiruxaspb
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, "snet channel" section has changed, since the need for the concept of initialized channels has disappeared.