Change deprecated pkg_resources favor of importlib.metadata #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sassless
requested changes
Jan 25, 2024
packages/sdk/setup.py
Outdated
| print("Installed modules:") | ||
| print(installed_modules) | ||
| return package_name in installed_modules | ||
| spec = importlib.util.find_spec(package_name) |
Member
There was a problem hiding this comment.
According to the importlib documentation this function
Find the spec for a module, optionally relative to the specified package name.
So this is not a function that is suitable for use here.
Based on the message from pkg_resources documentation, it is advisable to use the importlib_metadata package here instead of importlib.
A more specific function from this package might be importlib.metadata.metadata.
Member
There was a problem hiding this comment.
Finally the whole function might be:
import importlib.metadata # importlib_metadata need to be installed
def is_package_installed(package_name):
try:
package = importlib.metadata.metadata(package_name)
name, version = package.json["name"], package.json["version"]
print(f"Installed {name} {version}")
return True
except importlib.metadata.PackageNotFoundError:
print(f"Package {package_name} is not installed")
return False
Member
Author
|
@sassless Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing deprecated
pkg_resourcesfavor ofimportlib.metadata