Merged
Conversation
d5ec236 to
9bdb10b
Compare
som-sm
commented
Mar 14, 2026
Collaborator
Author
There was a problem hiding this comment.
For SomeExtend, we can't directly return true if the target is any because SomeExtend<[], any> should return false. So, adjusted AllExtend's implementation as well so that it stays aligned with the implementation of SomeExtend.
som-sm
commented
Mar 14, 2026
| // Optional elements | ||
| // If `exactOptionalPropertyTypes` were disabled, the target type would need an additional `| undefined` for a successful match. | ||
| // For example, `AllExtend<[1?, 2?], number>` would return `false`. To make it return `true`, the target type must be `number | undefined`. | ||
| // For example, `AllExtend<[1?, 2?], number>` would return `boolean`. To make it return `true`, the target type must be `number | undefined`. |
9bdb10b to
7ca0747
Compare
7ca0747 to
be4fdcb
Compare
Owner
|
Looks great 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SomeExtendtype, similar to theAllExtendtype.Closes #1379.