GreaterThan / LessThan / GreaterThanOrEqual / LessThanOrEqual: Fix behavior with the number type#1363
Merged
sindresorhus merged 2 commits intomainfrom Feb 9, 2026
Merged
Conversation
5315da4 to
77b20e3
Compare
77b20e3 to
7dd91dc
Compare
GreaterThan: Fix behavior with the number typeGreaterThan / LessThan / GreaterThanOrEqual / LessThanOrEqual: Fix behavior with the number type
7dd91dc to
232157a
Compare
232157a to
3a5ccdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if either argument is
number, the result isnever. Instead, the result should beboolean.In #1357, the following example is being added to
GreaterThan's doc:But this function can be called with a negative number if the type of the parameter is
number, like:Because currently
GreaterThan<number>returnsneverandneverextendstrue.Changing
GreaterThan<number>to returnbooleanprevents this becausebooleandoesn't extendtrue. And in case you wanted to allow thenumbertype, you could simply dotrue extends GreaterThan<N, 0>instead ofGreaterThan<N, 0> extends true.This PR also applies similar fix to
LessThan,GreaterThanOrEqualandLessThanOrEqual.