ConditionalPick: Fix returning {} instead of never when no keys match#1359
Merged
sindresorhus merged 3 commits intosindresorhus:mainfrom Feb 9, 2026
Merged
Conversation
som-sm
requested changes
Feb 8, 2026
8ffc5eb to
f698eb9
Compare
som-sm
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1197
Summary
Condition,ConditionalPickpreviously returnedPick<Base, never>which resolves to{}(empty object type). This allowed any properties to be assigned without type errors.ConditionalKeysreturnsneverusingIsNever, and returnsneverin that case.neverreturn behavior.Note
The same issue exists in
ConditionalPickDeep— tracked separately in #1358.