PackageJson: Use LiteralUnion for engines field#1354
Merged
sindresorhus merged 3 commits intosindresorhus:mainfrom Feb 8, 2026
Merged
PackageJson: Use LiteralUnion for engines field#1354sindresorhus merged 3 commits intosindresorhus:mainfrom
PackageJson: Use LiteralUnion for engines field#1354sindresorhus merged 3 commits intosindresorhus:mainfrom
Conversation
sindresorhus
approved these changes
Feb 8, 2026
som-sm
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1225
The
enginesfield uses'npm' | 'node' | stringas its mapped type key, which collapses to juststringin TypeScript — losing IDE autocomplete for common engine names.This applies
LiteralUnionto preserve'npm'and'node'as autocomplete suggestions, consistent with howos,cpu,homepage, andtypefields are already typed in the same file.