Paths: Fix behavior with WeakMaps / WeakSets#1348
Merged
sindresorhus merged 2 commits intomainfrom Feb 5, 2026
Merged
Conversation
8b1ff5b to
99c846c
Compare
som-sm
commented
Feb 5, 2026
|
|
||
| declare const anyLeaves: Paths<{a: {b: any}}, {leavesOnly: true}>; | ||
| expectType<'a.b'>(anyLeaves); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Intentionally skipped the following test:
declare const neverLeaves: Paths<{a: {b: never}}, {leavesOnly: true}>;
expectType<'a.b'>(neverLeaves);Because this one breaks currently, it's a simple fix, will open a separate PR for it.
sindresorhus
reviewed
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Cleans up the implementation of
Paths:Adds
WeakMapandWeakSetin the exclusion list.This PR is basically for the cleanup, it doesn't change any logic. The
WeakMap/WeakSetfix is included here because it's a pretty minor fix.