IsEqual: Fix generic inference#1306
Merged
sindresorhus merged 3 commits intosindresorhus:mainfrom Dec 2, 2025
Merged
Conversation
IsEqual: Fix generic inference issue.IsEqual: Fix generic inference issue #1305.
IsEqual: Fix generic inference issue #1305.IsEqual: Fix generic inference issue (#1305).
IsEqual: Fix generic inference issue (#1305).IsEqual: Fix generic inference
som-sm
requested changes
Dec 1, 2025
test-d/is-equal.ts
Outdated
Comment on lines
+89
to
+95
| // Test for Issue https://github.com/sindresorhus/type-fest/issues/1305 | ||
| type FieldProps<T1> = { | ||
| onChange: <T2>(value: T2, shouldBeTrue: IsEqual<T1, T2>) => void; | ||
| }; | ||
| const _TextField = <T>(value: T) => { | ||
| ({} as FieldProps<T>).onChange(value, true); // eslint-disable-line @typescript-eslint/consistent-type-assertions | ||
| }; |
Collaborator
There was a problem hiding this comment.
Use the following test instead:
Suggested change
| // Test for Issue https://github.com/sindresorhus/type-fest/issues/1305 | |
| type FieldProps<T1> = { | |
| onChange: <T2>(value: T2, shouldBeTrue: IsEqual<T1, T2>) => void; | |
| }; | |
| const _TextField = <T>(value: T) => { | |
| ({} as FieldProps<T>).onChange(value, true); // eslint-disable-line @typescript-eslint/consistent-type-assertions | |
| }; | |
| type Assignability<T, U, _V extends IsEqual<T, U>> = any; | |
| type TestAssignability<T> = Assignability<T, T, true>; |
This is easier to understand and aligns with other generic assignability tests that we have.
Contributor
Author
There was a problem hiding this comment.
Thanks, addressed.
som-sm
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1305.
This approach is similar to the fix previously implemented in 5af60a1.
Note:
I have intentionally ignored the
@typescript-eslint/consistent-type-assertionsrule in the test file (test-d/is-equal.ts) to accurately reflect and test the structure of the original reported issue code.