ReadonlyTuple: Deprecate in favour of TupleOf#1256
Merged
sindresorhus merged 3 commits intomainfrom Sep 30, 2025
Merged
Conversation
Owner
|
Maybe worth adding it to https://github.com/sindresorhus/type-fest?tab=readme-ov-file#alternative-type-names too? |
Collaborator
Author
Yeah, I thought this too, but do you wanna add this now or after we have removed the type? |
Owner
|
We can just do it now. When I type is deprecated, we can just pretend it doesn't exist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have
TupleOfexposed, I don't think we need a separateReadonlyTupletype because it simply wraps the result ofTupleOfinReadonly.This PR also refactors the implementation of
ReadonlyTupleto useTupleOf, which in turn fixes the following bug wherein the type wasn't distributing over theLengthargument.