Rename pure.zsh ---> pure.plugin.zsh#73
Closed
Tarrasch wants to merge 1 commit intosindresorhus:masterfrom
Closed
Conversation
This will then follow the conventions for * antigen: https://github.com/zsh-users/antigen * antigen-hs: https://github.com/Tarrasch/antigen-hs (enforced)
Contributor
Author
|
Hmm, if you find this name change to extreme (given the large user-base of this plugin), we might consider just doing something like I did for Tarrasch/zsh-bd@17139b7 |
Closed
Owner
|
I'd prefer a symlink. |
Contributor
Author
|
Sure, that's all valid, please check out #75 then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will then follow the conventions for
Feel free to say no to this, but I think we really should strive to standardize all the zsh plugins around github. There were some discussion in zsh-users/antigen#23. The reason I want to change it here is that I just got an email from a user who couldn't get the pure plugin to work with antigen-hs.
Cheers