Changed precision for default localeOptions#88
Merged
Conversation
Owner
|
Should this only be done when using the |
Contributor
Author
|
This logic actually wont interfere with non binary numbers in general, since after any 999 value the next value defaults to the next highest unit. However in a case such as: // with old code
prettyBytes(827181 * 10e25) // --> 82700000 YB
// with new code
prettyBytes(827181 * 10e25) // --> 82718100 YBUser gets an accurate value |
Owner
Can you add a test case for that? |
Contributor
Author
|
There you go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82
Was getting wrong results for 1023 and 1001 in default settings due to low precision.
Changed default to the precision of the integer part of the number because 1020 B is a huge round off from 1023 B.