Skip to content

Support AbortController#59

Merged
sindresorhus merged 15 commits intosindresorhus:mainfrom
cheap-glitch:abort-signal
Mar 19, 2022
Merged

Support AbortController#59
sindresorhus merged 15 commits intosindresorhus:mainfrom
cheap-glitch:abort-signal

Conversation

@cheap-glitch
Copy link
Copy Markdown
Contributor

Resolves #53

Comment thread index.js
Comment thread index.js Outdated
Comment thread test.js Outdated
Comment thread readme.md Outdated
Comment thread index.js Outdated
Comment thread index.js
Comment thread readme.md
Comment thread readme.md Outdated
@sindresorhus sindresorhus changed the title Add support for AbortSignal Support AbortController Feb 15, 2022
Comment thread index.js Outdated
Comment thread index.js Outdated
Comment thread index.js Outdated
@sindresorhus
Copy link
Copy Markdown
Owner

Tests are failing.

Comment thread index.js Outdated
Comment thread index.js Outdated
Copy link
Copy Markdown
Contributor Author

@cheap-glitch cheap-glitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did what I should have done earlier and tested the changes locally against all 3 versions of Node. Tests should all be green now

Comment thread test.js
@sindresorhus sindresorhus merged commit 352d62a into sindresorhus:main Mar 19, 2022
@sindresorhus
Copy link
Copy Markdown
Owner

Looks good :)

@fregante
Copy link
Copy Markdown

💯

@cheap-glitch cheap-glitch deleted the abort-signal branch March 19, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for AbortSignal

3 participants