Add support for boolean value for color option#244
Merged
sindresorhus merged 4 commits intosindresorhus:mainfrom Feb 2, 2025
Merged
Add support for boolean value for color option#244sindresorhus merged 4 commits intosindresorhus:mainfrom
boolean value for color option#244sindresorhus merged 4 commits intosindresorhus:mainfrom
Conversation
Owner
|
You have not updated all the places that needs updating. |
Contributor
Author
|
@sindresorhus I changed the type in the |
Owner
I think if you just checked instead of asking you would quickly see that you also need to update the readme. |
Contributor
Author
|
@sindresorhus updated the readme with the required type changes. |
false for default spinner color.boolean value for color option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
color property of class Ora can be a boolean
falsefor the default color of spinner, but the type hint only mentionsColorwhereas it should beColor | boolean.