Added string-width to dependencies#228
Merged
sindresorhus merged 1 commit intosindresorhus:mainfrom Aug 1, 2023
Merged
Conversation
Owner
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ora@7.0.0uses thestring-widthpackage, but doesn't include it as a dependency or peer-dependency.Implication
Users that install & import the latest version of
orafor the first time will run into the following runtime error ifstring-widthisn't specifically listed as a dependency or required by any other dependencies.This error is caused by Line 7 in
node_modules/ora/index.jsSolution
Add
string-widthas a dependency or peer-dependency in ora'spackage.json.{ "name": "ora", ... "dependencies": { ... "string-width": "^6.1.0" } }Problem & Solution Tested On
Last Working Version
ora@6.3.1) works as expected as it doesn't depend on or import thestring-widthpackage.