Replace get-stdin with Node's streamConsumers.buffer#24
Merged
sindresorhus merged 4 commits intosindresorhus:mainfrom Nov 10, 2025
Merged
Replace get-stdin with Node's streamConsumers.buffer#24sindresorhus merged 4 commits intosindresorhus:mainfrom
get-stdin with Node's streamConsumers.buffer#24sindresorhus merged 4 commits intosindresorhus:mainfrom
Conversation
watson
reviewed
May 20, 2025
Contributor
Author
|
I verified that the PR works as intended by doing |
|
Due to the missing |
Contributor
Author
|
Sure, will add a test case now |
Contributor
Author
|
is there anything left to be added @watson ? |
Contributor
Author
|
Seems like this fix has never been released, would it be possible to publish it on npm? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes
get-stdinin favor of built-instreamConsumers.buffer.The utility is available since Node 16, and the package targets Node 18+, which makes the change backwards compatible.
From
get-stdin's readme: