Fix systemroot inconsistent casing (Fixes #292)#299
Closed
Codex- wants to merge 1 commit intosindresorhus:mainfrom
Closed
Fix systemroot inconsistent casing (Fixes #292)#299Codex- wants to merge 1 commit intosindresorhus:mainfrom
Codex- wants to merge 1 commit intosindresorhus:mainfrom
Conversation
Owner
|
Author
Owner
|
Then open an issue on Node.js and add a code comment above your code change with a link to the Node.js issue. I prefer to only add workarounds when there's a chance it will be fixed properly at some point. |
Author
|
No problem, thanks anyway |
Owner
|
Why are you closing? |
Author
I'm unable to consistently reproduce this in a blank sandboxe, so I'm assuming that it must be some combination of our code and environment causing this as opposed to node or otherwise. If I find a more consistent reproduction in node, I'll re-open with an issue, until then I'm going to assume it's a me problem :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Long time no PR, sindresorhus 😄
This PR simply adds a fallback for casing differences in
SYSTEMROOTacross windows versions, currently when using this on W11 (at least the 3 versions I tested)SYSTEMROOTwas undefined, howeverSystemRootis defined.So, try and use both
Fixes #292