Merged
Conversation
index.js
Outdated
| win32: 'msedge', | ||
| linux: 'microsoft-edge' | ||
| }, { | ||
| wsl: '/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe', |
Owner
There was a problem hiding this comment.
You need to add the 64-bit path too.
Contributor
Author
There was a problem hiding this comment.
tested on windows with 64-bit edge, but looks like they still installed under x86 path only.
no idea why they didn't align this design with chrome.
Owner
|
You need to update the readme. |
Contributor
Author
|
updated the readme and indent issue, please review again and let me know if you need me to squash/rebase and force push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Chromium Edge support