Skip to content

Use PowerShell on Windows for improved reliability#188

Merged
sindresorhus merged 5 commits intosindresorhus:masterfrom
tim-stasse:master
Aug 21, 2020
Merged

Use PowerShell on Windows for improved reliability#188
sindresorhus merged 5 commits intosindresorhus:masterfrom
tim-stasse:master

Conversation

@tim-stasse
Copy link
Copy Markdown
Contributor

Fixes #173

@sindresorhus
Copy link
Copy Markdown
Owner

Why not use wslview as proposed in #173?

@tim-stasse
Copy link
Copy Markdown
Contributor Author

I wanted to, and actually based this change on it (it uses powershell under the hood). However it doesn't support passing additional arguments to the underlying start command in powershell and therefore wouldn't allow implementing the wait/app options.

@sindresorhus
Copy link
Copy Markdown
Owner

sindresorhus commented Aug 11, 2020

With this change, I guess the url option is moot? Since it was added because of & escaping problems on Windows. Maybe we should just remove that option now?

@tim-stasse
Copy link
Copy Markdown
Contributor Author

It's up to you really, that would be a breaking API change, but it—theoretically—won't actually break any existing usages if it's removed.

Let me know if you'd prefer to remove it as part of this change or not.

@sindresorhus
Copy link
Copy Markdown
Owner

We can remove it from the JS code, but it has to stay in the index.d.ts file (with a doc comment that it will be removed in the next major release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alternative URL opener on WSL - wslview

2 participants