Add tests for the config#495
Merged
Merged
Conversation
Collaborator
|
Could you add tests for more edge cases? (e.g. global config is only used when the global |
Contributor
Author
|
I added tests for the two only-edge cases. |
fe98489 to
5a43042
Compare
chinesedfan
approved these changes
Feb 22, 2020
sindresorhus
approved these changes
Feb 22, 2020
Collaborator
|
@bunysae Thanks for working on this! I left a couple of comments for you to take a look at, and overall this looks really solid (just a few implementation details I wanted to sort out). |
Contributor
Author
|
After @itaisteinherz comments i refactored the tests. |
bunysae
commented
Feb 27, 2020
itaisteinherz
approved these changes
Mar 3, 2020
itaisteinherz
left a comment
Collaborator
There was a problem hiding this comment.
@bunysae Thanks for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381. I used
proxyquirefor mocking the dependenciesis-installed-globallyandpkg-dir. Mocking withsinonwas not possible.IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor