Skip to content

Allow publishing if availability check fails#490

Merged
itaisteinherz merged 4 commits into
sindresorhus:masterfrom
terenceodonoghue:fix/check-availability
Feb 6, 2020
Merged

Allow publishing if availability check fails#490
itaisteinherz merged 4 commits into
sindresorhus:masterfrom
terenceodonoghue:fix/check-availability

Conversation

@terenceodonoghue

@terenceodonoghue terenceodonoghue commented Jan 20, 2020

Copy link
Copy Markdown
Contributor

Fixes #489

Before:

Screen Shot 2020-01-20 at 8 32 02 pm

After:

Screen Shot 2020-01-20 at 8 34 42 pm

Adds an additional check whereby if a package's availability cannot be determined, it will prompt to attempt the publish anyway.

Comment thread source/ui.js Outdated
Comment thread source/cli.js Outdated
Comment thread source/ui.js Outdated
Comment thread source/ui.js Outdated
Comment thread source/cli.js Outdated
Comment thread source/cli.js Outdated
@EronWright

Copy link
Copy Markdown

Ready to merge?

@terenceodonoghue

Copy link
Copy Markdown
Contributor Author

@EronWright not just yet; just need to fix PR per @itaisteinherz 's feedback then we'll see.

@itaisteinherz itaisteinherz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terenceodonoghue Thanks for working on this! 😄

@itaisteinherz itaisteinherz changed the title Allow publish if availability check fails Allow publishing if availability check fails Feb 6, 2020
@itaisteinherz itaisteinherz merged commit ccdb8a5 into sindresorhus:master Feb 6, 2020
@terenceodonoghue terenceodonoghue deleted the fix/check-availability branch February 6, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publishing to GitHub Packages yields 405 (Method Not Allowed)

3 participants