Require Node.js 10 (#32)

realityking · web-flow · commit 064e92dc47c6 · 2020-11-05T19:51:25.000+01:00
diff --git a/.travis.yml b/.travis.yml
@@ -8,6 +8,5 @@ node_js:
   - '14'
   - '12'
   - '10'
-  - '8'
 after_success:
   - './node_modules/.bin/nyc report --reporter=text-lcov > coverage.lcov && ./node_modules/.bin/codecov'
diff --git a/index.js b/index.js
@@ -2,9 +2,9 @@
 const fs = require('fs');
 const path = require('path');
 const {promisify} = require('util');
-const semver = require('semver');
+const semverGte = require('semver/functions/gte');
 
-const useNativeRecursiveOption = semver.satisfies(process.version, '>=10.12.0');
+const useNativeRecursiveOption = semverGte(process.version, '10.12.0');
 
 // https://github.com/nodejs/node/issues/8987
 // https://github.com/libuv/libuv/pull/1088
@@ -90,7 +90,7 @@ const makeDir = async (input, options) => {
 				if (!stats.isDirectory()) {
 					throw new Error('The path is not a directory');
 				}
-			} catch (_) {
+			} catch {
 				throw error;
 			}
 
@@ -143,7 +143,7 @@ module.exports.sync = (input, options) => {
 				if (!options.fs.statSync(pth).isDirectory()) {
 					throw new Error('The path is not a directory');
 				}
-			} catch (_) {
+			} catch {
 				throw error;
 			}
 		}
diff --git a/index.test-d.ts b/index.test-d.ts
@@ -8,7 +8,7 @@ import * as gfs from 'graceful-fs';
 expectType<Promise<string>>(makeDir('path/to/somewhere'));
 
 expectType<Promise<string>>(
-	makeDir('path/to/somewhere', {mode: parseInt('777', 8)})
+	makeDir('path/to/somewhere', {mode: 0o777})
 );
 expectType<Promise<string>>(makeDir('path/to/somewhere', {fs}));
 expectType<Promise<string>>(makeDir('path/to/somewhere', {fs: gfs}));
@@ -17,7 +17,7 @@ expectType<Promise<string>>(makeDir('path/to/somewhere', {fs: gfs}));
 expectType<string>(makeDirSync('path/to/somewhere'));
 
 expectType<string>(
-	makeDirSync('path/to/somewhere', {mode: parseInt('777', 8)})
+	makeDirSync('path/to/somewhere', {mode: 0o777})
 );
 expectType<string>(makeDirSync('path/to/somewhere', {fs}));
 expectType<string>(makeDirSync('path/to/somewhere', {fs: gfs}));
diff --git a/package.json b/package.json
@@ -11,7 +11,7 @@
 		"url": "https://sindresorhus.com"
 	},
 	"engines": {
-		"node": ">=8"
+		"node": ">=10"
 	},
 	"scripts": {
 		"test": "xo && nyc ava && tsd"
@@ -42,18 +42,18 @@
 		"file-system"
 	],
 	"dependencies": {
-		"semver": "^6.0.0"
+		"semver": "^7.3.2"
 	},
 	"devDependencies": {
 		"@types/graceful-fs": "^4.1.3",
-		"@types/node": "^13.7.1",
-		"ava": "^1.4.0",
+		"@types/node": "^14.14.6",
+		"ava": "^2.4.0",
 		"codecov": "^3.2.0",
 		"graceful-fs": "^4.1.15",
 		"nyc": "^15.0.0",
 		"path-type": "^4.0.0",
-		"tempy": "^0.2.1",
-		"tsd": "^0.11.0",
-		"xo": "^0.25.4"
+		"tempy": "^1.0.0",
+		"tsd": "^0.13.1",
+		"xo": "^0.34.2"
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,9 @@`
`2`	`2`	`const fs = require('fs');`
`3`	`3`	`const path = require('path');`
`4`	`4`	`const {promisify} = require('util');`
`5`		`-const semver = require('semver');`
	`5`	`+const semverGte = require('semver/functions/gte');`
`6`	`6`
`7`		`-const useNativeRecursiveOption = semver.satisfies(process.version, '>=10.12.0');`
	`7`	`+const useNativeRecursiveOption = semverGte(process.version, '10.12.0');`
`8`	`8`
`9`	`9`	`// https://github.com/nodejs/node/issues/8987`
`10`	`10`	`// https://github.com/libuv/libuv/pull/1088`
`@@ -90,7 +90,7 @@ const makeDir = async (input, options) => {`
`90`	`90`	`if (!stats.isDirectory()) {`
`91`	`91`	`throw new Error('The path is not a directory');`
`92`	`92`	`}`
`93`		`- } catch (_) {`
	`93`	`+ } catch {`
`94`	`94`	`throw error;`
`95`	`95`	`}`
`96`	`96`
`@@ -143,7 +143,7 @@ module.exports.sync = (input, options) => {`
`143`	`143`	`if (!options.fs.statSync(pth).isDirectory()) {`
`144`	`144`	`throw new Error('The path is not a directory');`
`145`	`145`	`}`
`146`		`- } catch (_) {`
	`146`	`+ } catch {`
`147`	`147`	`throw error;`
`148`	`148`	`}`
`149`	`149`	`}`