Add type and allowSymlinks options, only find files by default#4
Merged
sindresorhus merged 7 commits intosindresorhus:masterfrom May 4, 2019
coreyfarrell:check-type
Merged
Add type and allowSymlinks options, only find files by default#4sindresorhus merged 7 commits intosindresorhus:masterfrom coreyfarrell:check-type
type and allowSymlinks options, only find files by default#4sindresorhus merged 7 commits intosindresorhus:masterfrom
coreyfarrell:check-type
Conversation
type and followSymlinks options.type and followSymlinks options
Contributor
Author
|
@sindresorhus I've addressed your comments and modified readme.md, typescript definitions/tests. I really don't know typescript so hopefully I got that right. One final question I have: is |
sindresorhus
requested changes
May 4, 2019
sindresorhus
reviewed
May 4, 2019
type and followSymlinks optionstype and allowSymlinks options, only find files by default
sindresorhus
approved these changes
May 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not ready to merge, just seeking early feedback. The
conditional code for stat vs lstat is a bit much, can/should this
logic be shifted to path-type or another module?