Improve robustness of options.type#10
Merged
sindresorhus merged 3 commits intosindresorhus:mainfrom Jun 6, 2022
Merged
Conversation
The `type` option is validated at the top of both sync and async APIs. I ran `npm test` locally with no issues, but feel free to close if I'm missing something.
aaronccasanova
commented
Jun 5, 2022
|
|
||
| function checkType(type) { | ||
| if (type in typeMappings) { | ||
| if (Object.hasOwnProperty.call(typeMappings, type)) { |
Contributor
Author
There was a problem hiding this comment.
Was it intentional to look down the prototype chain?
I would expect this to be an invalid type error: await locatePath(files, 'toString');
typeMappings.hasOwnProperty may be more appropriate:
options.type
Owner
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
checkTypeto only allowtypeproperties on thetypeMappingsobject (as opposed to any property down the prototype chain). Removedtype === undefinedcheck inmatchTypeasoptions.typeis validated at the top of both sync and async APIs to befileordirectory. I rannpm testlocally with no issues, but feel free to close if I'm missing something.