Ignore non-Errors returned by beforeError hooks#833
Merged
sholladay merged 4 commits intosindresorhus:mainfrom Mar 2, 2026
Merged
Ignore non-Errors returned by beforeError hooks#833sholladay merged 4 commits intosindresorhus:mainfrom
sholladay merged 4 commits intosindresorhus:mainfrom
Conversation
This reverts commit 9618ca0.
sholladay
approved these changes
Mar 2, 2026
Collaborator
sholladay
left a comment
There was a problem hiding this comment.
Nice to have this. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small follow-up to the discussion in #804 / #508.
#829 resolved the main request by routing timeout (and other errors) through
beforeError.However, at runtime a
beforeErrorhook could still accidentally return a non-Errorvalue (e.g.undefined). Since the hook result was assigned directly, that could lead to throwing a non-Error.This PR adds a defensive guard so we only overwrite the processed error when the hook returns an
Errorinstance; otherwise we keep the current error.Context: In #804, maintainers confirmed this approach (“Yes, exactly.”) in the review thread: #804 (comment)