Skip to content

Update tough-cookie from 4.0.0 to 4.1.2#2184

Merged
sindresorhus merged 1 commit intosindresorhus:mainfrom
colincasey:fix/update_tough_cookie
Dec 4, 2022
Merged

Update tough-cookie from 4.0.0 to 4.1.2#2184
sindresorhus merged 1 commit intosindresorhus:mainfrom
colincasey:fix/update_tough_cookie

Conversation

@colincasey
Copy link
Copy Markdown
Contributor

@colincasey colincasey commented Nov 21, 2022

There is a bug in the 4.0.0 release of tough-cookie which causes cookies set on the localhost domain to be treated as an error. This has been fixed in later versions. This PR updates the dependency and fixes the related tests.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types. (not applicable)

There is a bug in the `4.0.0` release of `tough-cookie` which
causes `localhost` to be treated as an error.  This has been
fixed in later versions.
@colincasey colincasey marked this pull request as ready for review November 21, 2022 18:27
@sindresorhus sindresorhus merged commit 979272e into sindresorhus:main Dec 4, 2022
@colincasey colincasey deleted the fix/update_tough_cookie branch December 15, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants