feat: pagination parameters as object#1646
Closed
PopGoesTheWza wants to merge 3 commits intosindresorhus:mainfrom
PopGoesTheWza:pagination-parameters-as-object
Closed
feat: pagination parameters as object#1646PopGoesTheWza wants to merge 3 commits intosindresorhus:mainfrom PopGoesTheWza:pagination-parameters-as-object
pagination parameters as object#1646PopGoesTheWza wants to merge 3 commits intosindresorhus:mainfrom
PopGoesTheWza:pagination-parameters-as-object
Conversation
Contributor
Author
|
@szmarczak should I close this PR? |
Collaborator
|
Well I don't mind if yours gets merged instead :) @sindresorhus |
Owner
|
I went with #1644 as it was technically first (that's usually how I resolve duplicate PRs that are the same quality). Sorry for the wasted work @PopGoesTheWza. It was unfortunate that the timing was so so close. If you see any improvements to #1644 or the pagination code in general, we're more than happy to other PRs from you 🙌🏻 |
Contributor
Author
No worries. It offered me the possibility to criticize @szmarczak work! ;) |
Owner
PR reviews are the best kind of contribution, by the way. 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Fixes #1215
Checklist