Fix invalid afterResponse return check

szmarczak · szmarczak · commit cbc890292f40 · 2021-08-12T09:06:06.000+02:00
diff --git a/source/as-promise/index.ts b/source/as-promise/index.ts
@@ -98,7 +98,7 @@ export default function asPromise<T>(firstRequest: Request): CancelableRequest<T
 							throw new RetryError(request);
 						});
 
-						if (!(is.object(response) && is.number(response.statusCode) && response.body)) {
+						if (!(is.object(response) && is.number(response.statusCode) && !is.nullOrUndefined(response.body))) {
 							throw new TypeError('The `afterResponse` hook returned an invalid value');
 						}
 					}
diff --git a/test/hooks.ts b/test/hooks.ts
@@ -1351,3 +1351,19 @@ test('can retry without an agent', withServer, async (t, server, got) => {
 	t.is(response.retryCount, 2);
 	t.is(counter, 1);
 });
+
+test('does not throw on empty body when running afterResponse hooks', withServer, async (t, server, got) => {
+	server.get('/', (_request, response) => {
+		response.end();
+	});
+
+	await t.notThrowsAsync(got('', {
+		hooks: {
+			afterResponse: [
+				response => {
+					return response;
+				}
+			]
+		}
+	}));
+});

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ export default function asPromise<T>(firstRequest: Request): CancelableRequest<T`
`98`	`98`	`throw new RetryError(request);`
`99`	`99`	`});`
`100`	`100`
`101`		`- if (!(is.object(response) && is.number(response.statusCode) && response.body)) {`
	`101`	`+ if (!(is.object(response) && is.number(response.statusCode) && !is.nullOrUndefined(response.body))) {`
`102`	`102`	throw new TypeError('The `afterResponse` hook returned an invalid value');
`103`	`103`	`}`
`104`	`104`	`}`