Fix ignore and expandDirectories default handling#252
Merged
sindresorhus merged 1 commit intosindresorhus:mainfrom Jul 1, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks! I'm working on a CLI that forwards options from util.parseArgs to
globbyand encountered a runtime error whenundefinedis passed to theignoreoption. While investigating the error I found that both theignoreandexpandDirectoriesdefaults are overridden whenundefinedis passed. I've included this same patch in my program so feel free to close this PR if the existing behavior is expected 👋