Don't pass options.ignore to isGitIgnored#223
Merged
sindresorhus merged 1 commit intosindresorhus:mainfrom Jan 20, 2022
Merged
Conversation
Collaborator
Author
|
@sindresorhus After second thought, this Do you think we should remove it? |
Owner
|
No idea. It was added a long time ago. I do agree with your reasoning though. |
Collaborator
Author
|
It was added in #48, I think it's added for |
Owner
|
Yeah, let's remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignoreoption inisGitIgnored()mean to ignore.gitignorefiles, but when runningglobby(),ignoremean to ignore matched files.For example:
This mean to glob all files that's not
gitignored, but except.gitignorefile, not mean don't read the.gitignorefile.Before:
After:
This is a little hard to test, I didn't add.