Skip to content

Add test case for misidentified password-protected xlsx file#613

Merged
sindresorhus merged 2 commits intosindresorhus:mainfrom
vecerek:misidentified-password-protected-xlsx
Oct 26, 2023
Merged

Add test case for misidentified password-protected xlsx file#613
sindresorhus merged 2 commits intosindresorhus:mainfrom
vecerek:misidentified-password-protected-xlsx

Conversation

@vecerek
Copy link
Contributor

@vecerek vecerek commented Oct 26, 2023

This PR serves as a reproduction case for #612.

@sindresorhus
Copy link
Owner

Can you put it in failingFixture instead?

@vecerek vecerek force-pushed the misidentified-password-protected-xlsx branch from 2d653a8 to be45ef9 Compare October 26, 2023 11:25
@vecerek vecerek marked this pull request as ready for review October 26, 2023 11:25
@sindresorhus sindresorhus merged commit dc2a832 into sindresorhus:main Oct 26, 2023
@Borewit
Copy link
Collaborator

Borewit commented Dec 2, 2024

I think the identification of file-type is correct, the file provided is a Compound File Binary Format. It maybe a .xls format, but certainly not a .xlsx which is an OOXML format using ZIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants