Reduce msi false-positives#225
Merged
sindresorhus merged 2 commits intosindresorhus:masterfrom Aug 15, 2019
Merged
Conversation
Owner
|
We don't currently have any false-positive tests, but it shouldn't be hard to add here: https://github.com/sindresorhus/file-type/blob/43d3cd63b46ee7bc3d2c8cc7bfd0788f7291cec4/test.js |
Contributor
Author
|
@sindresorhus added support for false positive tests + corresponding fixture files Let me know if there's anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162
See #162 (comment)
Hi, is anyone able to provide true positive .msi files?
Using the following check I've been able to detect
msi-es (that I've found) without having a false positive on.doc,.xlsor.pptFull disclosure: I started with the commented out magic bytes from #162 (comment) but ended up just reading the byte stream of
msifiles.To get the tests passing the check is actually:
I'm shortening it to make it the largest subset of both ie.
I've got sample .ppt, .doc and .xls that I've tested this against and that don't return positive, how would I go about integrating them into the test suite @sindresorhus ?
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
msidetectionIssueHunt has been backed by the following sponsors. Become a sponsor