feat(error.js): Add cwd error property#565
Merged
sindresorhus merged 3 commits intosindresorhus:mainfrom Jul 26, 2023
homersimpsons:feature/error-cwd
Merged
feat(error.js): Add cwd error property#565sindresorhus merged 3 commits intosindresorhus:mainfrom homersimpsons:feature/error-cwd
cwd error property#565sindresorhus merged 3 commits intosindresorhus:mainfrom
homersimpsons:feature/error-cwd
Conversation
ehmicky
reviewed
Jul 14, 2023
ehmicky
reviewed
Jul 14, 2023
Collaborator
|
Thanks for the contribution @homersimpsons! We should also add:
Thanks again! |
Contributor
Author
|
Thank you for the feedback, I will certainly do this on Monday 24th |
Collaborator
|
Thanks, please take your time! |
ehmicky
reviewed
Jul 24, 2023
ehmicky
approved these changes
Jul 25, 2023
Collaborator
ehmicky
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks @homersimpsons.
What do you think @sindresorhus?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #564
(I couldn't find any contribution guidelines, so I hope everything is okay)
@ehmicky I let you review this