Allow cwd and localDir options to be URLs#492
Merged
sindresorhus merged 6 commits intomainfrom Feb 12, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #491
This allows the
cwdandlocalDiroptions to be URLs with thefile:scheme.This is not available in Node.js 12. We could potentially use
fileURLToPath()to convert it in Node.js 12. However, Node.js 12 support is ending in a little more than 2 months. Also, it would require detecting the Node.js version, which might addsemveras a production dependency. Overall, it does not seem to be worth it, but please let me know if you think otherwise.