Support AbortController#490
Support AbortController#490sindresorhus merged 21 commits intosindresorhus:mainfrom jopemachine:support-abort-controller
AbortController#490Conversation
|
Thanks a lot for this contribution @jopemachine! We might want to name this option More fundamentally, I am wondering whether the core |
Thanks for pointing it out, I just updated the option. |
|
Should I delete this document too? or should I mark the cancel method as |
There was a problem hiding this comment.
I believe we can directly delete that section of the documentation, good catch! 👍
Thanks again for this PR @jopemachine! There are a couple of things I have noted.
The tests look great! (But the CI tests are currently failing)
I appreciate your detailed feedback :) |
ehmicky
left a comment
There was a problem hiding this comment.
This looks good to me, thanks a lot @jopemachine!
Now waiting for another review from @sindresorhus.
Fixes #449.
I'd appreciate it if you could let me know if I need to write more tests or documents.
Thanks for all your efforts for this awesome library :)