Merged
Conversation
ehmicky
commented
Aug 13, 2024
| } | ||
|
|
||
| static isMocked = true; | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
I cannot find a simple way to run tests using Node without ICU support. So this mimics it for our purpose.
ehmicky
commented
Aug 13, 2024
| }; | ||
|
|
||
| // Execa computes the RegExp when first loaded, so we must delay this import | ||
| await import('./escape.js'); |
Collaborator
Author
There was a problem hiding this comment.
We could mock/unmock RegExp directly in escape.js, and run each test twice. But then each test would need to be serial. Also it makes the test file a little complex (this was my first approach). Using a separate test file that imports the other one results in less code.
Closed
|
When will it be released? :) |
Collaborator
Author
|
This has now been released in Is this working? |
|
Thank you. Yes :). Great Success. |
Collaborator
Author
|
Thanks for the shout out @Uzlopak, that's very kind! 🙏 |
|
Unfortunately, you are not on twitter, or else I would have linked you. |
This was referenced Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1143.
This PR does not add any documentation because this is a very tiny edge case that almost nobody will encounter:
result.escapedCommand) instead of being represented as a backslash sequence\u..., which is not a big problem.