Skip to content

Fix another complexity bug with types#1038

Merged
sindresorhus merged 1 commit intomainfrom
fix-complex-types-3
May 9, 2024
Merged

Fix another complexity bug with types#1038
sindresorhus merged 1 commit intomainfrom
fix-complex-types-3

Conversation

@ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 9, 2024

Fixes #1034.

This time for TypeScript 4.8.

@sindresorhus
Copy link
Owner

I don't think TS 4.8 is something we should care about.

@ehmicky
Copy link
Collaborator Author

ehmicky commented May 9, 2024

That sounds good to me. 👍
I'll open an issue about TypeScript versioning.

That being said, that PR might still be useful in that it reduces the types complexity, making them run a little faster. Also the code is a little smaller.

@sindresorhus sindresorhus merged commit cf70951 into main May 9, 2024
@sindresorhus sindresorhus deleted the fix-complex-types-3 branch May 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript Error TS2590: Expression produces a union type that is too complex to represent.

2 participants