Fix missing range() in createWithTimers() return value & require Node.js 10#55
Merged
sindresorhus merged 2 commits intosindresorhus:mainfrom Feb 1, 2021
novemberborn:fix-range-in-create-with-timers
Merged
Fix missing range() in createWithTimers() return value & require Node.js 10#55sindresorhus merged 2 commits intosindresorhus:mainfrom novemberborn:fix-range-in-create-with-timers
range() in createWithTimers() return value & require Node.js 10#55sindresorhus merged 2 commits intosindresorhus:mainfrom
novemberborn:fix-range-in-create-with-timers
Conversation
* DRY `delay` creation * Add test for range() and createWithTimers()
Owner
Can you revert that? Since the next major release (in April) will be to require ESM, so it would be a lot of churn to force TS users to switch to |
range() in createWithTimers() return value & require Node.js 10
Contributor
Author
|
Will do. |
Contributor
Author
|
Done (force-pushed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started with a simple bugfix:
delaycreationExcept that Node.js 6 doesn't do object spread. So I've changed this to require Node.js 10.
Which requires a breaking change, so I've removed the default export.
I'd appreciate this if this can ship without also upgrading to use ESM.